Update base.py #371
Update base.py #371
Conversation
Add `list' to acceptable type for `target_names`. It solves this issue: braindecode#370
braindecode/datasets/base.py
Outdated
| @@ -113,14 +113,16 @@ def set_description(self, description, overwrite=False): | |||
| self._description = pd.concat([self.description, description]) | |||
|
|
|||
| def _target_name(self, target_name): | |||
| if target_name is not None and type(target_name) not in [str, tuple]: | |||
| raise ValueError('target_name has to be None, str, tuple') | |||
| if target_name is not None and type(target_name) not in [str, tuple, list]: | |||
There was a problem hiding this comment.
this should be using isinstance
|
Thanks @MohammadJavadD for the PR, have tried to address comments and clean up a bit. @gemeinl would be nice if you can check if this makes sense for you or you anticipate any problems? |
Codecov Report
@@ Coverage Diff @@
## master #371 +/- ##
==========================================
+ Coverage 82.73% 82.74% +0.01%
==========================================
Files 53 53
Lines 3718 3721 +3
==========================================
+ Hits 3076 3079 +3
Misses 642 642 |
|
Thanks @MohammadJavadD @robintibor braindecode/braindecode/datautil/serialization.py Lines 139 to 141 in ad0ab1a It appears the usage of |
Add
listto acceptable types fortarget_names. It solves this issue: #370