Changing the name of function for sklearn compatibility. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 82.77% 82.66% -0.11%
==========================================
Files 53 53
Lines 3739 3739
==========================================
- Hits 3095 3091 -4
- Misses 644 648 +4 |
|
@bruAristimunha can you document the API change in https://github.com/braindecode/braindecode/blob/master/docs/whats_new.rst ? ok for you @robintibor @cedricrommel @gemeinl ? |
gemeinl
approved these changes
Jun 3, 2022
|
All seems good to me! Just don't get how come the coverage dropped... 🙃 |
|
@bruAristimunha can you document the API change in https://github.com/braindecode/braindecode/blob/master/docs/whats_new.rst ? |
agramfort
reviewed
Jun 3, 2022
agramfort
approved these changes
Jun 3, 2022
cedricrommel
approved these changes
Jun 7, 2022
|
Thx @bruAristimunha |
|
Happy to help! |
|
Great stuff thanks |
bruAristimunha
added a commit
to bruAristimunha/braindecode
that referenced
this pull request
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #382
As described in issue #382, a minor name change to allow hyperparameter search with GridsearchCV.