Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated depreciation #413

Merged

Conversation

bruAristimunha
Copy link
Collaborator

As discussed in issue #412, this PR defers the deprecation of the scale function, and updates tutorials where the function is used.

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #413 (fa59e76) into master (3fc8cd2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   84.17%   84.17%           
=======================================
  Files          46       46           
  Lines        3601     3601           
=======================================
  Hits         3031     3031           
  Misses        570      570           

@bruAristimunha bruAristimunha mentioned this pull request Sep 30, 2022
@bruAristimunha bruAristimunha changed the title Updated deprecated scale Updated depreciation Oct 3, 2022
Copy link
Collaborator

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guys I don't have much time these days. I let you approve and marge here.

@bruAristimunha bruAristimunha merged commit 0061a05 into braindecode:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants