Skip to content

Fix padding device in EEGResNet #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PierreGtch
Copy link
Collaborator

Fix #450

@bruAristimunha
Copy link
Collaborator

Hi @PierreGtch!

Nice catch! Can you please update the what's news file? When we get the green in CI, we can merge =)

@bruAristimunha bruAristimunha self-requested a review May 22, 2023 15:38
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #451 (81cbf02) into master (57e384d) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
+ Coverage   84.11%   84.13%   +0.01%     
==========================================
  Files          59       59              
  Lines        4269     4267       -2     
==========================================
- Hits         3591     3590       -1     
+ Misses        678      677       -1     

@bruAristimunha bruAristimunha merged commit d6169c8 into braindecode:master May 22, 2023
@bruAristimunha
Copy link
Collaborator

Thank you @PierreGtch!

@PierreGtch PierreGtch deleted the fix_padding_device_eegresnet branch May 22, 2023 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong padding device in EEGResNet if multiple GPUs are available
2 participants