-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessing classes #500
Preprocessing classes #500
Conversation
Codecov Report
@@ Coverage Diff @@
## master #500 +/- ##
==========================================
+ Coverage 84.27% 84.36% +0.08%
==========================================
Files 62 63 +1
Lines 4465 4495 +30
==========================================
+ Hits 3763 3792 +29
- Misses 702 703 +1 📢 Have feedback on the report? Share it here. |
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me, I could not check the tests.
Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add what's new and remove mne_preprocess.py
, and it is good to merge.
Great job @brunaafl & @bruAristimunha !
* Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Create side preprocessing classes based on mne (still revising) * Test file for the new functions * Test file for the new functions * Create side preprocessing classes based on mne (still revising) * Test file for new classes * Create side preprocessing classes based on mne (still revising) * adding pytest_cases * Adding new comments * Adding new comments * Adding new comments * Copying docstring from mne methods * Adding new classes to documentation * Adding new classes to API * Copying docstring * Copying docstring * Updating the setup * Apply suggestions from code review Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com> * Creating based on the function * Making private * Fixing doc * Removing * Removing * Updating the requirements.txt * Updating the whats_new.rst --------- Co-authored-by: Bru <a.bruno@aluno.ufabc.edu.br> Co-authored-by: Maciej Sliwowski <macieksliwowski@gmail.com>
-Not finished (+revising)
-Delete some comments
NOTE: pick_types() is a legacy function. New code should use inst.pick(...). --> so, I still need to change to pick