changed default value of final_conv_length to 'auto' in Deep4Net #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
=======================================
Coverage 84.48% 84.48%
=======================================
Files 63 63
Lines 4653 4653
=======================================
Hits 3931 3931
Misses 722 722 |
sliwy
force-pushed
the
fix_deep4net_default
branch
from
80bec63 to
398dafd
Compare
|
good catch! and what about shallow? should be same Problem there no? |
|
for shallow |
|
Thank you @sliwy =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After last changes, default value of
final_conv_lengthinDeep4NetisNoneand code fails. Before it was mandatory to provide this paramter. I'm setting default to `"auto" -> it should not break earlier code as before it had to be specified.