Repository navigation
[augmentation] fix type hints for Output of Transform.forward - #551
Merged
Merged
Conversation
Contributor
Author
|
seems that fixed the trailing whitespaces as well (flake8 should now pass, although we should switch to ruff - yes, saw the other PR) |
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
=======================================
Coverage 83.73% 83.74%
=======================================
Files 63 63
Lines 4821 4822 +1
=======================================
+ Hits 4037 4038 +1
Misses 784 784 |
Contributor
Author
|
@bruAristimunha any idea why the Windows test are failing? seems it's failing why before running tests, during a pip install that fails EDIT: i've tried to fix it in the workflow file. If you can re-run the CI build to check |
Collaborator
|
Okay. Thank you @tgy for fixing the CI for the window. All good for me =) |
Collaborator
|
Thank you for fix type @tgy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outputtype annotation, now reflecting that it can returnyas atuple of
torch.TensorOperationtype hint, to annotate theTransform.operationattribute, to better check operation return types
Batch,OutputandOperationas type aliases