[WIP] Adding Attention Base Net - #572
Conversation
|
@agramfort FYI |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #572 +/- ##
==========================================
+ Coverage 86.47% 87.14% +0.67%
==========================================
Files 63 65 +2
Lines 5419 5733 +314
==========================================
+ Hits 4686 4996 +310
- Misses 733 737 +4 |
|
Can you help with some tests @martinwimpff? |
Sure, what kind of tests are you looking for? I saw that the doumentation for the attention modules is still missing. Are you already working on that @bruAristimunha or should I add them? |
|
Please go ahead |
|
There are two test sets that I see here, one of the model like I'm doing with BioT. Another of the attention functions @martinwimpff |
Co-authored-by: Martin Wimpff <42936990+martinwimpff@users.noreply.github.com>
|
pinging @martinwimpff |
|
Maybe this help you @martinwimpff: https://tighten.com/insights/adding-commits-to-a-pull-request/ |
|
pinging @tomMoral |
tomMoral
left a comment
There was a problem hiding this comment.
A few comments but overall this looks good (did not check in details)
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
|
Model integrated @martinwimpff! |
|
Thank you for the review @tomMoral |
Hey @martinwimpff!
I am starting a new round of braindecode's models with your models.