Skip to content

[WIP] Adding Attention Base Net - #572

Merged
bruAristimunha merged 67 commits into
braindecode:masterfrom
bruAristimunha:add-base-attention
Apr 22, 2024
Merged

bruAristimunha merged 67 commits into
braindecode:masterfrom
bruAristimunha:add-base-attention

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

Hey @martinwimpff!

I am starting a new round of braindecode's models with your models.

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

@agramfort FYI

@codecov

codecov Bot commented Feb 14, 2024 •

Copy link
Copy Markdown

Codecov Report

Merging #572 (09adfb4) into master (97eba44) will increase coverage by 0.67%.
The diff coverage is 98.72%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
+ Coverage   86.47%   87.14%   +0.67%     
==========================================
  Files          63       65       +2     
  Lines        5419     5733     +314     
==========================================
+ Hits         4686     4996     +310     
- Misses        733      737       +4     

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

Can you help with some tests @martinwimpff?

@bruAristimunha bruAristimunha changed the title Adding Attention Base Net [WIP] Adding Attention Base Net Feb 14, 2024
Comment thread braindecode/models/functions_attention.py Outdated
Comment thread docs/api.rst Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
@martinwimpff

Copy link
Copy Markdown
Collaborator

Can you help with some tests @martinwimpff?

Sure, what kind of tests are you looking for?

I saw that the doumentation for the attention modules is still missing. Are you already working on that @bruAristimunha or should I add them?

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

Please go ahead

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

There are two test sets that I see here, one of the model like I'm doing with BioT. Another of the attention functions @martinwimpff

bruAristimunha and others added 2 commits February 16, 2024 13:17
Co-authored-by: Martin Wimpff <42936990+martinwimpff@users.noreply.github.com>
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

pinging @martinwimpff

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

pinging @tomMoral

@tomMoral tomMoral left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but overall this looks good (did not check in details)

Comment thread braindecode/models/functions.py Outdated
Comment thread test/unit_tests/models/test_models.py Outdated
Comment thread braindecode/models/modules_attention.py Outdated
Comment thread braindecode/models/attentionbasenet.py Outdated
@bruAristimunha
bruAristimunha merged commit e15f28c into braindecode:master Apr 22, 2024
@bruAristimunha
bruAristimunha deleted the add-base-attention branch April 22, 2024 21:55
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

Model integrated @martinwimpff!

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

Thank you for the review @tomMoral

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants