Skip to content

[MRG] Adding BIOT to braindecode - #573

Merged
agramfort merged 30 commits into
braindecode:masterfrom
bruAristimunha:biot
Feb 19, 2024
Merged

agramfort merged 30 commits into
braindecode:masterfrom
bruAristimunha:biot

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

No description provided.

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

FYI @JessyD

@codecov

codecov Bot commented Feb 14, 2024 •

Copy link
Copy Markdown

Codecov Report

Merging #573 (004b4e6) into master (4d38af3) will increase coverage by 0.76%.
The diff coverage is 93.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #573      +/-   ##
==========================================
+ Coverage   83.32%   84.08%   +0.76%     
==========================================
  Files          63       64       +1     
  Lines        4821     4908      +87     
==========================================
+ Hits         4017     4127     +110     
+ Misses        804      781      -23     

@agramfort agramfort left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to add tests. I would also ping on the PR the original authors if they want to have a look

Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
Comment thread test/unit_tests/models/test_models.py Resolved
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

pinging in can you want to give any feedback @ycq091044

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

@agramfort, I am happy with the PR; it is okay for me to merge. Can you take a last look? 🙏🏽

Comment thread braindecode/models/biot.py Resolved
Comment thread braindecode/models/biot.py Resolved
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

The green bottom is your @agramfort =)

@agramfort agramfort left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agramfort agramfort changed the title [WIP] Adding BIOT to braindecode [MERG] Adding BIOT to braindecode Feb 19, 2024
@agramfort agramfort changed the title [MERG] Adding BIOT to braindecode [MRG] Adding BIOT to braindecode Feb 19, 2024
@agramfort
agramfort merged commit 7b9872c into braindecode:master Feb 19, 2024
@agramfort

Copy link
Copy Markdown
Collaborator

thx @bruAristimunha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants