Repository navigation
[MRG] Adding BIOT to braindecode - #573
Merged
Merged
Conversation
Collaborator
Author
|
FYI @JessyD |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 83.32% 84.08% +0.76%
==========================================
Files 63 64 +1
Lines 4821 4908 +87
==========================================
+ Hits 4017 4127 +110
+ Misses 804 781 -23 |
agramfort
reviewed
Feb 15, 2024
agramfort
left a comment
Collaborator
There was a problem hiding this comment.
you'll need to add tests. I would also ping on the PR the original authors if they want to have a look
bruAristimunha
commented
Feb 15, 2024
bruAristimunha
commented
Feb 15, 2024
Collaborator
Author
|
pinging in can you want to give any feedback @ycq091044 |
Collaborator
Author
|
@agramfort, I am happy with the PR; it is okay for me to merge. Can you take a last look? 🙏🏽 |
agramfort
reviewed
Feb 16, 2024
Collaborator
Author
|
The green bottom is your @agramfort =) |
Collaborator
|
thx @bruAristimunha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.