[MRG] TUH: standardize channel name and define their positions - #593
Merged
bruAristimunha merged 13 commits intoApr 23, 2024
Conversation
PierreGtch
marked this pull request as ready for review
April 13, 2024 19:17
PierreGtch
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #593 +/- ##
==========================================
- Coverage 87.14% 86.88% -0.26%
==========================================
Files 65 65
Lines 5733 5758 +25
==========================================
+ Hits 4996 5003 +7
- Misses 737 755 +18 |
PierreGtch
changed the title
bruAristimunha
approved these changes
Apr 15, 2024
Collaborator
|
Hey @agramfort, |
bruAristimunha
approved these changes
Apr 22, 2024
Collaborator
|
The error is not related @PierreGtch, fixing in another PR |
Collaborator
|
Solved @PierreGtch! |
Closed
Collaborator
|
thank you @PierreGtch! |
Collaborator
|
Hey @agramfort, I think you are busy, and as I had already done the review, I chose to apply the merge to fix the braindecode, which is linked and explained in the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives the option to rename the channels of
TUHto match the 1005 system and set the montage to get their positions