Add type hints to preprocessing functions - #600
Merged
bruAristimunha merged 5 commits intoMay 8, 2024
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #600 +/- ##
=======================================
Coverage 86.89% 86.89%
=======================================
Files 65 65
Lines 5759 5768 +9
=======================================
+ Hits 5004 5012 +8
- Misses 755 756 +1 |
agramfort
approved these changes
May 7, 2024
agramfort
left a comment
Collaborator
There was a problem hiding this comment.
diff looks good but I feel we here need to add mypy support to check that it's actually correct.
+1 for merge and add mypy CI job in another PR
Collaborator
|
Thank you @PierreGtch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.