Skip to content

Add type hints to preprocessing functions - #600

Merged
bruAristimunha merged 5 commits into
braindecode:masterfrom
PierreGtch:add-typehints-preprocess
May 8, 2024
Merged

Add type hints to preprocessing functions#600
bruAristimunha merged 5 commits into
braindecode:masterfrom
PierreGtch:add-typehints-preprocess

Conversation

@PierreGtch

Copy link
Copy Markdown
Collaborator

No description provided.

@PierreGtch
PierreGtch requested a review from bruAristimunha May 7, 2024 16:44
@codecov

codecov Bot commented May 7, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.89%. Comparing base (095e70c) to head (8074c08).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #600   +/-   ##
=======================================
  Coverage   86.89%   86.89%           
=======================================
  Files          65       65           
  Lines        5759     5768    +9     
=======================================
+ Hits         5004     5012    +8     
- Misses        755      756    +1     

@agramfort agramfort left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff looks good but I feel we here need to add mypy support to check that it's actually correct.

+1 for merge and add mypy CI job in another PR

@bruAristimunha
bruAristimunha merged commit 629b6bb into braindecode:master May 8, 2024
@bruAristimunha

Copy link
Copy Markdown
Collaborator

Thank you @PierreGtch

This was referenced May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants