Code clarity changes in windowers.py - #615
Merged
Merged
Conversation
- the `samp` in `first_samp` refers to a sample (i.e., inclusive indexing), make it same for `last_samp` - a few wording changes that make things clearer to me Feel free to revert any or all of it
OverLordGoldDragon
changed the title
windowers.pywindowers.py
Contributor
Author
|
Re: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
=======================================
Coverage 87.20% 87.20%
=======================================
Files 67 67
Lines 5925 5925
=======================================
Hits 5167 5167
Misses 758 758 |
agramfort
approved these changes
May 18, 2024
bruAristimunha
enabled auto-merge (squash)
May 20, 2024 17:15
Collaborator
|
Thank you for your contribution @OverLordGoldDragon! I hope to see you more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sampinfirst_samprefers to a sample (i.e., inclusive indexing), make it same forlast_sampFeel free to revert any or all of it