Skip to content

Exposing activation function - #637

Merged
bruAristimunha merged 26 commits into
braindecode:masterfrom
bruAristimunha:exposing-activation
Sep 25, 2024
Merged

bruAristimunha merged 26 commits into
braindecode:masterfrom
bruAristimunha:exposing-activation

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

closes #636

@codecov

codecov Bot commented Sep 21, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (d37a694) to head (504fba4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #637      +/-   ##
==========================================
+ Coverage   87.33%   87.36%   +0.02%     
==========================================
  Files          67       67              
  Lines        6073     6084      +11     
==========================================
+ Hits         5304     5315      +11     
  Misses        769      769              

Comment thread braindecode/models/atcnet.py Outdated
Comment thread braindecode/models/atcnet.py Outdated
Comment thread braindecode/models/biot.py
# Conflicts:
#	braindecode/models/biot.py
#	braindecode/models/eeginception.py
#	braindecode/models/eegnet.py
#	docs/whats_new.rst
#	test/unit_tests/models/test_integration.py
@bruAristimunha
bruAristimunha removed the request for review from agramfort September 25, 2024 14:08
@bruAristimunha
bruAristimunha merged commit 018f7bc into braindecode:master Sep 25, 2024
@bruAristimunha
bruAristimunha deleted the exposing-activation branch September 25, 2024 14:08
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

I thought better of it @agramfort, and I think you're pretty busy this week, I'll try to move a little faster, but your review is always welcome on any PR you want to review 🙏🏽
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activation functions not exposed in all models.

2 participants