EHN: including EEGTCNet - #640
Merged
Merged
Conversation
Collaborator
Author
|
The global comments about this code... It is already good, but it does not use the braindecode dependencies (EEGNetV4 and TCN). The main limitation is the dimensionality issue that I am thinking more about. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #640 +/- ##
==========================================
+ Coverage 87.36% 87.55% +0.19%
==========================================
Files 67 68 +1
Lines 6084 6180 +96
==========================================
+ Hits 5315 5411 +96
Misses 769 769 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this neural network, we can fully remove deep learning support from moabb. Related with benchopt BCI, cc. @tomMoral.