Skip to content

[EHN] EEGMiner - #667

Merged
bruAristimunha merged 28 commits into
braindecode:masterfrom
bruAristimunha:eegminer
Oct 16, 2024
Merged

[EHN] EEGMiner#667
bruAristimunha merged 28 commits into
braindecode:masterfrom
bruAristimunha:eegminer

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

Small benchmark

Cross-Session
image
image

Cross-Subject:
image

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

I am planning only to include tests

Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py
Comment thread braindecode/models/eegminer.py
@codecov

codecov Bot commented Oct 9, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (c316bcc) to head (e9cd97b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage   86.58%   86.90%   +0.31%     
==========================================
  Files          72       73       +1     
  Lines        6450     6604     +154     
==========================================
+ Hits         5585     5739     +154     
  Misses        865      865              

Comment thread braindecode/models/eegminer.py Outdated
Comment thread docs/whats_new.rst Outdated
@bruAristimunha
bruAristimunha marked this pull request as ready for review October 10, 2024 12:52
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/functions.py Outdated
Comment thread braindecode/models/eegminer.py
Comment thread braindecode/models/eegminer.py Outdated
Comment thread braindecode/models/eegminer.py Outdated
@sylvchev

Copy link
Copy Markdown
Collaborator

@mccorsi it could be interesting to see if others functional connectivity could be used with this type of neural architecture

@sylvchev

Copy link
Copy Markdown
Collaborator

Regarding the licence, you could add a NOTICE file to indicate that EEGMiner is CC by-nc

@mccorsi

mccorsi commented Oct 15, 2024

Copy link
Copy Markdown

Hi @sylvchev, do have constraints on the FC matrices you want to use (ie should they have to be SPD...)? I might have some ideas but I'd like to be sure that it makes sense for the project! :)

@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

No constraints on the FC @mccorsi and @sylvchev

@sylvchev sylvchev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thanks @bruAristimunha !

@bruAristimunha
bruAristimunha merged commit abf9ffe into braindecode:master Oct 16, 2024
@bruAristimunha
bruAristimunha deleted the eegminer branch October 16, 2024 07:14
@mccorsi

mccorsi commented Oct 16, 2024

Copy link
Copy Markdown

Here is a non-exhaustive list of FC metrics :

  • Coherence-based metrics: cf the one already implemented in pyriemann & used in FUCONE
  • more generally, mne-python increased the set of spectral FC metrics: Coherence, Coherency, Imaginary part of Coherency, Canonical Coherency (CaCoh), Maximised Imaginary part of Coherency (MIC), Multivariate Interaction Measure (MIM), Phase-Locking Value (PLV), Corrected Imaginary PLV (ciPLV), Pairwise Phase Consistency (PPC), Phase Lag Index (PLI), Unbiased estimator of squared PLI, Directed PLI (DPLI), Weighted PLI (WPLI), Debiased estimator of squared WPLI, State-space Granger Causality (GC), State-space GC on time-reversed signals
  • bicoherence: to measure the coherence from two different bins of frequency

I am currently working on metrics that would capture non-linearities but it is still under development. I will let you know when it is ready (and implemented in python)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants