Skip to content

[EHN] Inclusion of SincShallowNet - #678

Merged
bruAristimunha merged 9 commits into
braindecode:masterfrom
bruAristimunha:including-sinc-shallow
Oct 26, 2024
Merged

bruAristimunha merged 9 commits into
braindecode:masterfrom
bruAristimunha:including-sinc-shallow

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

No description provided.

@codecov

codecov Bot commented Oct 22, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 94.52055% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (b86d9fa) to head (3e282f8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
+ Coverage   87.13%   87.21%   +0.07%     
==========================================
  Files          75       76       +1     
  Lines        6739     6812      +73     
==========================================
+ Hits         5872     5941      +69     
- Misses        867      871       +4     

Comment thread braindecode/models/sinc_shallow.py Outdated
Comment thread braindecode/models/sinc_shallow.py Outdated
Comment thread braindecode/models/sinc_shallow.py Outdated
Comment thread braindecode/models/sinc_shallow.py Outdated
Comment thread docs/whats_new.rst Outdated
@bruAristimunha
bruAristimunha merged commit 5a4e341 into braindecode:master Oct 26, 2024
Comment on lines +286 to +291
high_freqs = torch.clamp(
low_freqs + torch.abs(self.bandwidths),
min=self.min_freq,
max=self.sfreq / 2.0,
)
bandwidths = high_freqs - low_freqs

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

normalization matters here.

Get the model after the training and before (check if the random stage initialization is the same).

@bruAristimunha bruAristimunha Feb 4, 2025 •

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already solved on EEGMiner.

self.f_mean = nn.Parameter(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants