Skip to content

Small fixes on BIDS datasets - #704

Merged
bruAristimunha merged 9 commits into
braindecode:masterfrom
PierreGtch:fix-bids
Mar 5, 2025
Merged

Small fixes on BIDS datasets#704
bruAristimunha merged 9 commits into
braindecode:masterfrom
PierreGtch:fix-bids

Conversation

@PierreGtch

@PierreGtch PierreGtch commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

Issues I found while using these datasets:

  • the ‘suffix’ should be ”epo”, not the datatype
  • not useful to have datatypes=“eeg” by default
  • sometimes the annotations are not set in _epo.fif files but we can still recover the event names using the events and event_id attributes

@PierreGtch

Copy link
Copy Markdown
Collaborator Author

The tests fail because I used the MOABB cache as BIDS dataset for the tests, but there is a small issue in the way they are saved at the moment.

For more details, see NeuroTechX/moabb#707

@bruAristimunha

Copy link
Copy Markdown
Collaborator

Does releasing moabb after merge solve the problem? It is only affected epoch data?

@bruAristimunha

Copy link
Copy Markdown
Collaborator

I looked again the file, it all the cache...

@PierreGtch

Copy link
Copy Markdown
Collaborator Author

Does releasing moabb after merge solve the problem? It is only affected epoch data?

It affects epochs and array epochs

Comment thread docs/whats_new.rst Outdated
@codecov

codecov Bot commented Mar 5, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.29%. Comparing base (507103a) to head (e337366).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
- Coverage   87.30%   87.29%   -0.01%     
==========================================
  Files          78       78              
  Lines        7208     7219      +11     
==========================================
+ Hits         6293     6302       +9     
- Misses        915      917       +2     

@bruAristimunha
bruAristimunha merged commit 928920d into braindecode:master Mar 5, 2025
@PierreGtch
PierreGtch deleted the fix-bids branch March 5, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants