Small fixes on BIDS datasets - #704
Merged
Merged
Conversation
Collaborator
Author
|
The tests fail because I used the MOABB cache as BIDS dataset for the tests, but there is a small issue in the way they are saved at the moment. For more details, see NeuroTechX/moabb#707 |
Collaborator
|
Does releasing moabb after merge solve the problem? It is only affected epoch data? |
Collaborator
|
I looked again the file, it all the cache... |
Collaborator
Author
It affects epochs and array epochs |
bruAristimunha
approved these changes
Mar 5, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #704 +/- ##
==========================================
- Coverage 87.30% 87.29% -0.01%
==========================================
Files 78 78
Lines 7208 7219 +11
==========================================
+ Hits 6293 6302 +9
- Misses 915 917 +2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues I found while using these datasets:
”epo”, not thedatatypedatatypes=“eeg”by defaulteventsandevent_idattributes