Skip to content

[EHN] FBLightConvNet - #723

Merged
bruAristimunha merged 5 commits into
braindecode:masterfrom
bruAristimunha:fbcnet-light
Apr 17, 2025
Merged

[EHN] FBLightConvNet#723
bruAristimunha merged 5 commits into
braindecode:masterfrom
bruAristimunha:fbcnet-light

Conversation

@bruAristimunha

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • braindecode/models/summary.csv: Language not supported
Comments suppressed due to low confidence (1)

braindecode/models/fblightconvnet.py:50

  • The docstring contains a grammatical error in the 'Final Layer' description ('to with kernel sizes'); consider rephrasing it for clarity.
through a linear layer to with kernel sizes matching the input dimensions to integrate features across different channels generate the final output predictions.

@codecov

codecov Bot commented Apr 17, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.

Project coverage is 87.46%. Comparing base (8b443e5) to head (ab7abfc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   87.41%   87.46%   +0.04%     
==========================================
  Files          79       80       +1     
  Lines        7313     7388      +75     
==========================================
+ Hits         6393     6462      +69     
- Misses        920      926       +6     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bruAristimunha
bruAristimunha requested a review from Copilot April 17, 2025 12:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • braindecode/models/summary.csv: Language not supported
  • docs/whats_new.rst: Language not supported
Comments suppressed due to low confidence (1)

braindecode/models/fblightconvnet.py:180

  • The input_size passed to _LightweightConv1d is self.n_filters_spat, but the forward method of _LightweightConv1d reshapes the input to use the number of heads (self.heads) as the channel dimension. Ensure that self.n_filters_spat equals self.heads or adjust the reshaping logic in _LightweightConv1d to prevent a potential dimension mismatch.
self.attn_conv = _LightweightConv1d(self.n_filters_spat, (self.n_times // self.win_len), heads=self.heads, weight_softmax=weight_softmax, bias=bias)

Comment thread braindecode/models/fblightconvnet.py Outdated
Comment thread braindecode/models/fblightconvnet.py Outdated
Comment thread braindecode/models/fblightconvnet.py Outdated
Comment thread braindecode/models/fblightconvnet.py
Comment thread braindecode/models/modules.py
@bruAristimunha
bruAristimunha merged commit eca08c2 into braindecode:master Apr 17, 2025
@bruAristimunha
bruAristimunha deleted the fbcnet-light branch April 17, 2025 15:57
@bruAristimunha

Copy link
Copy Markdown
Collaborator Author

thank you @martinwimpff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants