[EHN] FBLightConvNet - #723
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- braindecode/models/summary.csv: Language not supported
Comments suppressed due to low confidence (1)
braindecode/models/fblightconvnet.py:50
- The docstring contains a grammatical error in the 'Final Layer' description ('to with kernel sizes'); consider rephrasing it for clarity.
through a linear layer to with kernel sizes matching the input dimensions to integrate features across different channels generate the final output predictions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #723 +/- ##
==========================================
+ Coverage 87.41% 87.46% +0.04%
==========================================
Files 79 80 +1
Lines 7313 7388 +75
==========================================
+ Hits 6393 6462 +69
- Misses 920 926 +6 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- braindecode/models/summary.csv: Language not supported
- docs/whats_new.rst: Language not supported
Comments suppressed due to low confidence (1)
braindecode/models/fblightconvnet.py:180
- The input_size passed to _LightweightConv1d is self.n_filters_spat, but the forward method of _LightweightConv1d reshapes the input to use the number of heads (self.heads) as the channel dimension. Ensure that self.n_filters_spat equals self.heads or adjust the reshaping logic in _LightweightConv1d to prevent a potential dimension mismatch.
self.attn_conv = _LightweightConv1d(self.n_filters_spat, (self.n_times // self.win_len), heads=self.heads, weight_softmax=weight_softmax, bias=bias)
martinwimpff
approved these changes
Apr 17, 2025
Collaborator
Author
|
thank you @martinwimpff |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.