Repository navigation
Update SCCNet and EEGNex and enhance documentation - #742
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 87.73% 87.75% +0.01%
==========================================
Files 94 94
Lines 7567 7576 +9
==========================================
+ Hits 6639 6648 +9
Misses 928 928 🚀 New features to boost your workflow:
|
bruAristimunha
changed the title
martinwimpff
approved these changes
Apr 28, 2025
martinwimpff
left a comment
martinwimpff
left a comment
Collaborator
There was a problem hiding this comment.
Looks good @bruAristimunha!
Only thing that could be improved is the calculation of self.in_features for EEGNeX.
The current one won't work for all input lengths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the
SCCNetclass for better compatibility with the referenced paper and update the "What's New" section to reflect recent changes and improvements.closes #741