Set models to start in train mode by default - #745
Merged
bruAristimunha merged 2 commits intoMay 6, 2025
Conversation
Collaborator
Author
|
I am changing some behaviour that you both defined a long time way for three nn.Sequential models, can you review if it makes sense for you guys, @robintibor and @gemeinl. The behaviour always starts the model with the evaluation model. This behaviour is always overridden if we are using skorch/eegclassifier, but this generates a silent error in PyTorch Lightning. I will merge on Monday at the end of the day, as I am judging that the request made by @dungscout96 makes sense and the tests are green. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #745 +/- ##
=======================================
Coverage 87.75% 87.75%
=======================================
Files 94 94
Lines 7576 7577 +1
=======================================
+ Hits 6648 6649 +1
Misses 928 928 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure all models initialize in train mode instead of eval mode to facilitate training from the start.
closes: #744