[FIX] Embedding size parameters should be index based on the conv and depth parameters - #760
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the CTNet model to improve its embedding configuration flexibility by making embedding-related parameters optional and implementing automatic dimension inference.
- Converts
emb_size,n_filters_time, anddepth_multiplierparameters to optional with automatic inference when one is missing - Adds comprehensive parameter validation and dimension resolution logic
- Includes a new test to verify models with embedding parameters work correctly with different embedding values
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| braindecode/models/ctnet.py | Refactors CTNet to make embedding parameters optional with automatic inference and adds validation logic |
| test/unit_tests/models/test_integration.py | Adds new test function to verify models with embedding parameters work with modified values |
| docs/whats_new.rst | Documents the CTNet parameter fix in the changelog |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bruAristimunha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.