Simulation hoi script #26
Conversation
There was a problem hiding this comment.
Hi @aopy,
Please find a changes that should be made before merging.
Thanks a lot, let me know if you need help or a feedback
hoi/simulation/simulation_hois.py
Outdated
| ############################################################################### | ||
|
|
||
|
|
||
| def simulation_hois_beh( |
There was a problem hiding this comment.
If I understood correctly, this one uses a dynamic behavioral variable. Since it's not used here, you can remove it
hoi/simulation/simulation_hois.py
Outdated
| return cov_ | ||
|
|
||
|
|
||
| def simulate_hois_gauss( |
There was a problem hiding this comment.
can you replace the simul_hois by the name simulate_hois_gauss?
hoi/simulation/simulation_hois.py
Outdated
| n_trials=1000, | ||
| n_nodes=12, | ||
| n_times=None, | ||
| data_type="array", |
There was a problem hiding this comment.
Some inputs are not used. You can remove them :
data_typetarget_fritesamplitude
hoi/simulation/simulation_hois.py
Outdated
| can be conducted for a specified number of trials and nodes, | ||
| with an optional time component. | ||
|
|
||
| Parameters: |
There was a problem hiding this comment.
For the documentation, can you please follow the Numpydoc convention? For example
One line description (<79 chars).
Several lines description.
Parameters
-----------------
x: type
Description
y: type
Description
Returns
-----------
o: type
Description
p: type
DescriptionAnd same for other functions.
hoi/simulation/simulation_hois.py
Outdated
|
|
||
| simulated_data = sim_rand | ||
|
|
||
| return [simulated_data[:, :12, :], sim_hois[:, 12, 0]] |
There was a problem hiding this comment.
Output list is not necessary. Just simulated_data[:, :12, :], sim_hois[:, 12, 0]. Btw, it's a bit weird to have hard-coded variables like 12...
No description provided.