Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isc: `phaseshift_isc` overlaps with `brainiak.utils.phase_randomize` #396

Closed
mihaic opened this issue Dec 17, 2018 · 2 comments

Comments

@mihaic
Copy link
Contributor

commented Dec 17, 2018

We should not have duplicate functionality.

@mihaic mihaic added this to the v0.9 milestone Jan 11, 2019

@snastase

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

These are not really functional duplicates. I think in theory what we want is (a) phaseshift_isc, which performs the nonparametric test using phase randomization and returns a null distribution, p-values, etc; and (b) a more generic phase_randomize utility that simply takes in time-series and phase-randomizes them. I think having this phase_randomize utility is useful even outside the context of ISC analysis. And ideally, the phaseshift_isc function should use the phase_randomize function internally. This was a little tricky because the pairwise and leave-one-out ISC approaches apply the phase randomization slightly differently, but should be work now—see #405 (commit dba670a). I've updated phaseshift_isc in isc, utils and tests to match.

@mihaic

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

There's a way to close issues with commit messages such that it is clear they were fixed. I think we should use it in the future:
https://help.github.com/articles/closing-issues-using-keywords/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.