Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: Document difference between compute_p_from_null_distribution and p_from_null #397

Closed
mihaic opened this issue Dec 17, 2018 · 3 comments

Comments

@mihaic
Copy link
Contributor

commented Dec 17, 2018

@mihaic mihaic added this to the v0.9 milestone Jan 10, 2019

@snastase

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2019

As far as I can tell p_from_null was performing a specific function that was only used in the old isfc function, and is no longer referenced anywhere in brainiak. In this case, I think compute_p_from_null_distribution supersedes p_from_null, and p_from_null can be removed. However, I may shorten the name of compute_p_from_null_distribution as I only named it this to not overlap with the pre-existing p_from_null.

@mihaic

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

That makes sense. Please remember to include a news item about the removal of p_from_null (see point 7 http://brainiak.org/docs/contributing.html#how-to-contribute). Looking forward to the PR!

@snastase

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

Replaced old p_from_null with newer functionality from compute_p_from_null_distribution in #405 (commit daa5d41). Note that the new functionality now uses the older simpler function name. This also required removing the ecdf functionality which is no longer used anywhere in BrainIAK (commit aa0c37d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.