New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wheel building during installation from PyPI #61

Open
mihaic opened this Issue Jul 13, 2016 · 3 comments

Comments

Projects
None yet
1 participant
@mihaic
Contributor

mihaic commented Jul 13, 2016

There is a difference in the behavior of pip install based on the package specification. When installing form Git, it installs the dependencies before building the wheel. When installing from PyPI, it first tries to build the wheel, and only then it installs the dependencies. Here are relevant excerpts:

pip3 install -v git+https://github.com/IntelPNI/brainiak@v0.1

  Using cached pybind11-1.8.1-py2.py3-none-any.whl
  Downloading from URL https://pypi.python.org/packages/e8/bb/cb21c4b8da28d94df193bd83fe399e13dd38b7eba6fed52546d4fb1c2908/pybind11-1.8.1-py2.py3-none-any.whl#md5=468347b8f3c1114c6cb23df6b4186bbb (from https://pypi.python.org/simple/pybind11/)
Installing collected packages: pybind11, brainiak

  Running setup.py install for brainiak ...

pip install -v brainiak

  Using cached pybind11-1.8.1-py2.py3-none-any.whl
  Downloading from URL https://pypi.python.org/packages/e8/bb/cb21c4b8da28d94df193bd83fe399e13dd38b7eba6fed52546d4fb1c2908/pybind11-1.8.1-py2.py3-none-any.whl#md5=468347b8f3c1114c6cb23df6b4186bbb (from https://pypi.python.org/simple/pybind11/)
Building wheels for collected packages: brainiak
  Running setup.py bdist_wheel for brainiak ...

[verbose output showing it fails because pybind11 is not installed]

Failed to build brainiak
Installing collected packages: pybind11, brainiak

  Running setup.py install for brainiak ...

@mihaic mihaic added bug dev labels Jul 13, 2016

@mihaic mihaic self-assigned this Jul 13, 2016

@mihaic

This comment has been minimized.

Show comment
Hide comment
@mihaic
Contributor

mihaic commented Jul 14, 2016

@mihaic

This comment has been minimized.

Show comment
Hide comment
@mihaic

mihaic Jul 14, 2016

Contributor

I am re-tagging this as "enhancement" because it does not really break anything. It only scares the users who might think something is wrong. The installation continues fine, even if the wheel is not built.

Contributor

mihaic commented Jul 14, 2016

I am re-tagging this as "enhancement" because it does not really break anything. It only scares the users who might think something is wrong. The installation continues fine, even if the wheel is not built.

@mihaic mihaic added enhancement and removed bug labels Jul 14, 2016

@mihaic

This comment has been minimized.

Show comment
Hide comment
@mihaic

mihaic Jul 14, 2016

Contributor

Another argument to leave this be and wait for PEP 518 to be implemented: The latest version of SciPy has the same problem.

$ pip3 install scipy-0.18.0rc2.tar.gz 
Processing ./scipy-0.18.0rc2.tar.gz
Collecting numpy>=1.7.1 (from scipy==0.18.0rc2)
  Using cached numpy-1.11.1-cp34-cp34m-manylinux1_x86_64.whl
Building wheels for collected packages: scipy
  Running setup.py bdist_wheel for scipy ... error
  Complete output from command /home/mihai/.tmp/venv/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-qmy92i29-build/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmpz0exbw4ipip-wheel- --python-tag cp34:
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-qmy92i29-build/setup.py", line 415, in <module>
      setup_package()
    File "/tmp/pip-qmy92i29-build/setup.py", line 395, in setup_package
      from numpy.distutils.core import setup
  ImportError: No module named 'numpy'

  ----------------------------------------
  Failed building wheel for scipy
Contributor

mihaic commented Jul 14, 2016

Another argument to leave this be and wait for PEP 518 to be implemented: The latest version of SciPy has the same problem.

$ pip3 install scipy-0.18.0rc2.tar.gz 
Processing ./scipy-0.18.0rc2.tar.gz
Collecting numpy>=1.7.1 (from scipy==0.18.0rc2)
  Using cached numpy-1.11.1-cp34-cp34m-manylinux1_x86_64.whl
Building wheels for collected packages: scipy
  Running setup.py bdist_wheel for scipy ... error
  Complete output from command /home/mihai/.tmp/venv/bin/python3 -u -c "import setuptools, tokenize;__file__='/tmp/pip-qmy92i29-build/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" bdist_wheel -d /tmp/tmpz0exbw4ipip-wheel- --python-tag cp34:
  Traceback (most recent call last):
    File "<string>", line 1, in <module>
    File "/tmp/pip-qmy92i29-build/setup.py", line 415, in <module>
      setup_package()
    File "/tmp/pip-qmy92i29-build/setup.py", line 395, in setup_package
      from numpy.distutils.core import setup
  ImportError: No module named 'numpy'

  ----------------------------------------
  Failed building wheel for scipy

@mihaic mihaic changed the title from Fix installation from PyPI to Fix wheel building during installation from PyPI Jul 29, 2016

danielsuo pushed a commit that referenced this issue Nov 16, 2017

Merge pull request #61 from amplab/multinode
Make it possible to start multiple nodes in a cluster

danielsuo pushed a commit that referenced this issue Nov 16, 2017

Redis Server started in Tests now shutdowns at end of tests (#61)
Redis Server started in tests now shutdowns at end of tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment