Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simulator #135

Merged
merged 12 commits into from Oct 13, 2016
Merged

Add simulator #135

merged 12 commits into from Oct 13, 2016

Conversation

@CameronTEllis
Copy link
Contributor

@CameronTEllis CameronTEllis commented Oct 12, 2016

No description provided.

@mihaic
mihaic approved these changes Oct 12, 2016
Copy link
Contributor

@mihaic mihaic left a comment

Looks good. I will merge it after the checks are done.

On a different note, why do you keep closing PRs and opening new ones for the same code? You know that you can simply push new commits to the same branch of your GitHub fork and they will show up in the existing PR, right? Closing a PR makes it harder to follow up on previous comments.

@mihaic
Copy link
Contributor

@mihaic mihaic commented Oct 13, 2016

Review ready.

@mihaic mihaic merged commit ad9c427 into brainiak:master Oct 13, 2016
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linux Build finished.
Details
macos Build finished.
Details
danielsuo pushed a commit that referenced this pull request Nov 16, 2017
danielsuo pushed a commit that referenced this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.