/brainiak

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corr comp #159

Merged
merged 12 commits into from Jan 13, 2017

Conversation

Reviewers

@mihaic mihaic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yidawang @mihaic
@yidawang
Contributor

yidawang commented Jan 13, 2017

Add a high-performance correlation computation function using BLAS wrapped in Cython to brainiak/fcma/util. Running at least one order of magnitude faster than np.corrcoef.

Ours: 100 loops, best of 3: 14.2 ms per loop
np.corrcoef: 10 loops, best of 3: 153 ms per loop
Show outdated Hide outdated brainiak/fcma/util.py
Show outdated Hide outdated brainiak/fcma/util.py

yidawang added some commits Jan 13, 2017

@yidawang
addressing review comments
Loading status checks…
5827956
@yidawang
add more math derivation
Loading status checks…
530b185
@yidawang
more docstring issues
Loading status checks…
285b1ea
Show outdated Hide outdated brainiak/fcma/util.py
Show outdated Hide outdated brainiak/fcma/util.py
@yidawang
more review comments
Loading status checks…
d0c9984
@mihaic

mihaic approved these changes Jan 13, 2017
View changes

@mihaic mihaic merged commit 6d4c11d into brainiak:master Jan 13, 2017
2 of 3 checks passed

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
linux Build finished.
Details
macos Build finished.
Details

@yidawang yidawang deleted the yidawang:corr_comp branch Jan 13, 2017

danielsuo pushed a commit that referenced this pull request Nov 16, 2017

@robertnishihara @pcmoritz
Attempt to free up to 20% of the plasma store capacity during evictio… 
…n. (#159)
26941e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment