Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ISFC to use the new I/O and image modules #209

Merged
merged 2 commits into from Apr 25, 2017

Conversation

@mihaic
Copy link
Contributor

@mihaic mihaic commented Apr 21, 2017

No description provided.

@mihaic mihaic requested a review from cbaldassano Apr 21, 2017
@mihaic
Copy link
Contributor Author

@mihaic mihaic commented Apr 21, 2017

@cbaldassano, I think the changes to ISFC are minor. Could you please review?

Copy link
Collaborator

@cbaldassano cbaldassano left a comment

Looks good! Thank you for refactoring this interface

@mihaic
Copy link
Contributor Author

@mihaic mihaic commented Apr 25, 2017

@cbaldassano, thanks for the review.

@mihaic mihaic merged commit 917cfa8 into brainiak:master Apr 25, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
linux Build finished.
Details
macos Build finished.
Details
@mihaic mihaic deleted the mihaic:refactor-isfc branch Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.