New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to eventseg #266

Merged
merged 4 commits into from Sep 20, 2017

Conversation

Projects
None yet
2 participants
@cbaldassano
Collaborator

cbaldassano commented Sep 19, 2017

Minor update to eventseg to support additional use case, added ipython notebook eventseg example, also updated download link in isfc example

cbaldassano added some commits Sep 18, 2017

Minor update to eventseg to support additional use case, added ipytho…
…n notebook eventseg example, also updated download link in isfc example
@mihaic

Great looking tutorial! So far, we have been committing example code without outputs, for ease of tracking changes. Clearly it is helpful to have the outputs visible on the web. I will merge your PR (after you address the minor comment) and try to solve the problem in issue #268.

Show outdated Hide outdated brainiak/eventseg/event.py
@mihaic

This comment has been minimized.

Show comment
Hide comment
@mihaic

mihaic Sep 19, 2017

Contributor

You should also update the paper reference to point to Neuron.

Contributor

mihaic commented Sep 19, 2017

You should also update the paper reference to point to Neuron.

@mihaic

mihaic approved these changes Sep 20, 2017

@mihaic mihaic merged commit 785599a into brainiak:master Sep 20, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
linux Build finished.
Details
macos Build finished.
Details

@cbaldassano cbaldassano deleted the cbaldassano:eventseg_Sept17 branch Sep 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment