Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict multiprocessing to available CPUs #293

Merged
merged 1 commit into from Nov 8, 2017

Conversation

@mihaic
Copy link
Contributor

@mihaic mihaic commented Nov 7, 2017

See issue #291.

See issue #291.
Copy link
Member

@yidawang yidawang left a comment

Good by me for the FCMA part. I would approve if the Searchlight part looks good, too.

Copy link
Contributor

@mjanderson09 mjanderson09 left a comment

Does this impact performance?

@mihaic
Copy link
Contributor Author

@mihaic mihaic commented Nov 8, 2017

Good question, @mjanderson09. I see no reason for performance to change. In practice, I see the same the same performance on genre_searchlight_example with pool_size=None:

# before
Searchlight Done:  4.976254463195801
# after
Searchlight Done:  4.268961191177368
@mihaic mihaic merged commit 21aa882 into brainiak:master Nov 8, 2017
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linux Build finished.
Details
macos Build finished.
Details
@mihaic mihaic deleted the mihaic:respect-cpuset branch Nov 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants