Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conda packaging #328

Merged
merged 15 commits into from Feb 13, 2018
Merged

Add Conda packaging #328

merged 15 commits into from Feb 13, 2018

Conversation

@danielsuo
Copy link
Member

@danielsuo danielsuo commented Feb 2, 2018

Create Conda packages and test in Travis. A few outstanding issues

  • Update documentation (README, website, docs)
  • Understand why Linux build is hanging on test_brsa.py for Travis, but not anywhere else link
  • Confirm whether users need apt install build-essential or xcode-select install
  • Upload to anaconda.org

Unrelated issues: code coverage (see #327 and #326).

@danielsuo danielsuo added this to the v0.7 milestone Feb 2, 2018
@danielsuo danielsuo self-assigned this Feb 2, 2018
@danielsuo danielsuo requested a review from mihaic Feb 2, 2018
Copy link
Contributor

@mihaic mihaic left a comment

Looks good. I will add the documentation.

Loading

.conda/bld.bat Outdated
@@ -0,0 +1,10 @@
:: NOTE: Windows not supported!
Copy link
Contributor

@mihaic mihaic Feb 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this script necessary?

Loading

@danielsuo
Copy link
Member Author

@danielsuo danielsuo commented Feb 2, 2018

Loading

@danielsuo
Copy link
Member Author

@danielsuo danielsuo commented Feb 2, 2018

Ok, initially looks good; not sure about code coverage or hanging tests though. It'll be good to get wider user testing before we make a more public change.

Loading

@mihaic
Copy link
Contributor

@mihaic mihaic commented Feb 2, 2018

@danielsuo, can you please add to CONTRIBUTING instructions for uploading Conda package?

Loading

@danielsuo
Copy link
Member Author

@danielsuo danielsuo commented Feb 2, 2018

Loading

@mihaic
Copy link
Contributor

@mihaic mihaic commented Feb 2, 2018

Yes.

Loading

@danielsuo
Copy link
Member Author

@danielsuo danielsuo commented Feb 2, 2018

Loading

@mihaic
Copy link
Contributor

@mihaic mihaic commented Feb 9, 2018

I propose we update the website after making the release.

As far as I understand, we do not need build-essential on Linux after switching to using the Conda compilers:
https://conda.io/docs/user-guide/tasks/build-packages/compiler-tools.html

The MacOS requirements situation is less clear to me. @danielsuo, if you have access to a MacOS VM, can you try installing the package without first installing Xcode? I uploaded one to my channel:
https://anaconda.org/mihaic/brainiak

With the new compilers all tests are passing.

Finally, we will upload to the brainiak channel after the release.

Loading

mihaic
mihaic approved these changes Feb 9, 2018
@mihaic mihaic merged commit efd59d7 into brainiak:master Feb 13, 2018
5 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants