Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventseg bugfix #339

Merged
merged 4 commits into from Feb 20, 2018
Merged

Eventseg bugfix #339

merged 4 commits into from Feb 20, 2018

Conversation

@cbaldassano
Copy link
Collaborator

@cbaldassano cbaldassano commented Feb 20, 2018

Fixes a bug in eventseg caused by reusing a range variable as an iterator. This was causing the iterator to start at the incorrect timestep on the backwards pass, making the forwards and backwards passes asymmetric.

@cbaldassano cbaldassano requested a review from mihaic Feb 20, 2018
@mihaic
mihaic approved these changes Feb 20, 2018
@mihaic mihaic merged commit de8f90f into brainiak:master Feb 20, 2018
5 checks passed
5 checks passed
@codecov
codecov/patch 100% of diff hit (target 88.34%)
Details
@codecov
codecov/project 88.34% (+0%) compared to 41ed77f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@buildbot-princeton
linux Build finished.
Details
@buildbot-princeton
macos Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants