New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ball shape searchlight #348
Conversation
Looks good! (Pdb) print(b.mask_[3,:]) |
brainiak/searchlight/searchlight.py
Outdated
@@ -95,6 +95,32 @@ def __init__(self, rad): | |||
self.mask_[r1, r2, r3] = True | |||
|
|||
|
|||
class Ball(Shape): | |||
"""Diamond |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Ball searchlight shape"?
…to or less than rad instead of just less than. So I just updated the docstring slightly. Please double check this is correct
@lcnature, regardless of your off-by-one question (@mjanderson09?), please add unit tests for the new |
@mihaic Done. Thanks! |
Thanks, @lcnature. I am sure your |
No description provided.