Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ball shape searchlight #348

Merged
merged 4 commits into from Mar 23, 2018
Merged

add ball shape searchlight #348

merged 4 commits into from Mar 23, 2018

Conversation

lcnature
Copy link
Contributor

No description provided.

@mjanderson09
Copy link
Contributor

Looks good!

(Pdb) print(b.mask_[3,:])
[[False False False False False False False False False False False]
[False False False True True True True True False False False]
[False False True True True True True True True False False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False False True True True True True True True False False]
[False False False True True True True True False False False]
[False False False False False False False False False False False]]

mihaic
mihaic requested changes Mar 22, 2018
View reviewed changes
brainiak/searchlight/searchlight.py Outdated
@@ -95,6 +95,32 @@ def __init__(self, rad):
self.mask_[r1, r2, r3] = True


class Ball(Shape):
"""Diamond
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ball searchlight shape"?

I think Diamond also chooses voxels with Manhattan distnace of equal …
65c94d9 
…to or less than rad instead of just less than. So I just updated the docstring slightly. Please double check this is correct
@mihaic
Copy link
Member

mihaic commented Mar 22, 2018

@lcnature, regardless of your off-by-one question (@mjanderson09?), please add unit tests for the new Ball class to pass the coverage check.

@lcnature
Copy link
Contributor Author

@mihaic Done. Thanks!

@mihaic mihaic merged commit 83e6cf7 into brainiak:master Mar 23, 2018
@mihaic
Copy link
Member

mihaic commented Mar 23, 2018

Thanks, @lcnature. I am sure your Ball shape will be very popular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihaic mihaic mihaic approved these changes

@mjanderson09 mjanderson09 mjanderson09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lcnature @mjanderson09 @mihaic