Eventseg updates #353
Merged
Eventseg updates #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaic
requested changes
Mar 26, 2018
brainiak/eventseg/event.py
Outdated
|
|
||
| P: n_events+1 by n_events+1 ndarray | ||
| HMM transition matrix | ||
|
|
There was a problem hiding this comment.
I am not sure if someone was really using these attributes, but please add a "removal" news fragment announcing their removal.
There was a problem hiding this comment.
I actually decided to revert this change and keep these attributes publicly exposed, especially since the P matrix is now more complicated and so it could help users to debug.
| @@ -60,14 +60,12 @@ class EventSegment(BaseEstimator): | |||
| n_iter: int : default 500 | |||
| Maximum number of steps to run during fitting | |||
|
|
|||
| event_chains: ndarray with length = n_events | |||
| Array with unique value for each separate chain of events, each linked | |||
| in the order they appear in the array | |||
There was a problem hiding this comment.
As far as I can tell, this is the first time the term "chain" is used. I think it would help to provide a definition.
There was a problem hiding this comment.
Good idea, I added more info to the top of the file
mihaic
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making transition matrix more flexible, and improving utility functions and tests