Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
brainiak/eventseg/event.py
Outdated
| P: n_events+1 by n_events+1 ndarray | ||
| HMM transition matrix | ||
This comment has been minimized.
This comment has been minimized.
mihaic
Mar 26, 2018
Contributor
I am not sure if someone was really using these attributes, but please add a "removal" news fragment announcing their removal.
This comment has been minimized.
This comment has been minimized.
cbaldassano
Mar 27, 2018
Collaborator
I actually decided to revert this change and keep these attributes publicly exposed, especially since the P matrix is now more complicated and so it could help users to debug.
| @@ -60,14 +60,12 @@ class EventSegment(BaseEstimator): | ||
| n_iter: int : default 500 | ||
| Maximum number of steps to run during fitting | ||
| event_chains: ndarray with length = n_events | ||
| Array with unique value for each separate chain of events, each linked | ||
| in the order they appear in the array |
This comment has been minimized.
This comment has been minimized.
mihaic
Mar 26, 2018
Contributor
As far as I can tell, this is the first time the term "chain" is used. I think it would help to provide a definition.
This comment has been minimized.
This comment has been minimized.
mihaic
merged commit fe604af
into
brainiak:master
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
cbaldassano commentedMar 26, 2018
Making transition matrix more flexible, and improving utility functions and tests