New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventseg updates #353

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
2 participants
@cbaldassano
Collaborator

cbaldassano commented Mar 26, 2018

Making transition matrix more flexible, and improving utility functions and tests

P: n_events+1 by n_events+1 ndarray
HMM transition matrix

This comment has been minimized.

@mihaic

mihaic Mar 26, 2018

Contributor

I am not sure if someone was really using these attributes, but please add a "removal" news fragment announcing their removal.

This comment has been minimized.

@cbaldassano

cbaldassano Mar 27, 2018

Collaborator

I actually decided to revert this change and keep these attributes publicly exposed, especially since the P matrix is now more complicated and so it could help users to debug.

@@ -60,14 +60,12 @@ class EventSegment(BaseEstimator):
n_iter: int : default 500
Maximum number of steps to run during fitting
event_chains: ndarray with length = n_events
Array with unique value for each separate chain of events, each linked
in the order they appear in the array

This comment has been minimized.

@mihaic

mihaic Mar 26, 2018

Contributor

As far as I can tell, this is the first time the term "chain" is used. I think it would help to provide a definition.

This comment has been minimized.

@cbaldassano

cbaldassano Mar 27, 2018

Collaborator

Good idea, I added more info to the top of the file

@mihaic

mihaic approved these changes Mar 27, 2018

@mihaic mihaic merged commit fe604af into brainiak:master Mar 27, 2018

5 checks passed

codecov/patch 100% of diff hit (target 88.36%)
Details
codecov/project 88.81% (+0.44%) compared to 83e6cf7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
linux Build finished.
Details
macos Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment