Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fit parameters #372
Sorry for my delay. It looks much nicer! I also like the notebook example. I left some comments for your consideration.
@CameronTEllis Yes I think it is almost good to go. Please see the two added comments. Regarding SFNR - I know that there is no correct way to do it. Maybe it is OK to leave it as is. But we should be very cautious as this might cause some problem if other properties in noise_dict interact with this parameter.
Looks good, that is a good check in case you accidentally pass in a numpy array…
On Sun, Sep 2, 2018 at 9:09 AM Mingbo Cai ***@***.***> wrote: adding a check that `magnitude` is indeed a list @CameronTEllis I added a line in 2864 of fmrisim.py to check for the type of `magnitude` (in case a numpy array of size 1 is fed). Please check if this is appropriate. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: d6e3959
-- *Cameron Ellis* *PhD Candidate (Turk-Browne lab)Department of PsychologyYale University*