Fixed unnecessary Pool creation in searchlight #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When pool_size=1 the creation of a multiprocessing pool is unnecessary and wasteful because data needs to be copied and sent to other process. This would double the needed memory for each MPI task. In addition, fork() can cause unpredictable behaviour in some MPI implementations, see: https://www.open-mpi.org/faq/?category=tuning#fork-warning
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Jenkins, add to whitelist. |
|
Jenkins, retest this please. |
|
Do we need a unit test for pool_size = 1 to get coverage up? Am I reading this correctly? |
|
Precisely! |
|
Ok, I copied one of the previous tests with the only difference being pool_size=1. Test passes and coverage was good on my end. Third times the charm hopefully :) |
mihaic
approved these changes
Oct 16, 2018
|
Thanks a lot, @davidt0x! This should make some people happy. :) |
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
Jun 21, 2019
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
Jun 21, 2019
mihaic
added a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pool_size=1 the creation of a multiprocessing pool is unnecessary
and wasteful because data needs to be copied and sent to other process.
This would double the needed memory for each MPI task. In addition,
fork() can cause unpredictable behaviour in some MPI implementations,
see:
https://www.open-mpi.org/faq/?category=tuning#fork-warning