Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option in BRSA to set the prior of SNR to be "equal" across all voxels #387

Merged
merged 5 commits into from Oct 25, 2018
Merged

Add an option in BRSA to set the prior of SNR to be "equal" across all voxels #387

merged 5 commits into from Oct 25, 2018

Conversation

@lcnature
Copy link
Contributor

@lcnature lcnature commented Oct 22, 2018

No description provided.

@lcnature lcnature requested a review from mihaic Oct 22, 2018
Copy link
Contributor

@mihaic mihaic left a comment

Please fix the whitespace error.

lcnature
@mihaic
Copy link
Contributor

@mihaic mihaic commented Oct 24, 2018

The new errors are unrelated to this PR. I'll fix them.

mihaic added a commit to mihaic/brainiak that referenced this pull request Oct 24, 2018
From Python 3.6 release notes:
"A backslash-character pair that is not a valid escape sequence now
generates a DeprecationWarning. Although this will eventually become a
SyntaxError, that will not be for several Python releases."
https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior

This became a run-checks.sh error and was causing builds to fail in PR brainiak#387 starting with pycodestyle 2.4.0:
https://pycodestyle.readthedocs.io/en/latest/developer.html
mihaic added a commit that referenced this pull request Oct 24, 2018
From Python 3.6 release notes:
"A backslash-character pair that is not a valid escape sequence now
generates a DeprecationWarning. Although this will eventually become a
SyntaxError, that will not be for several Python releases."
https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior

This became a run-checks.sh error and was causing builds to fail in PR #387 starting with pycodestyle 2.4.0:
https://pycodestyle.readthedocs.io/en/latest/developer.html
@mihaic
mihaic approved these changes Oct 25, 2018
@mihaic mihaic merged commit 16cbb44 into brainiak:master Oct 25, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
linux Build finished.
Details
macos Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants