Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup.py #529

Closed
wants to merge 1 commit into from
Closed

Update setup.py #529

wants to merge 1 commit into from

Conversation

CameronTEllis
Copy link
Contributor

The new versions of statsmodels have broken fmrisim. In particular, they have removed the calls for ARMA models and replaced them with a new ARIMA model. The latest version compatible with fmrisim is 0.12.0

@CameronTEllis
Update setup.py
796cdce 
The new versions of statsmodels have broken fmrisim. In particular, they have removed the calls for ARMA models and replaced them with a new ARIMA model. The latest version compatible with fmrisim is 0.12.0
@CameronTEllis
Copy link
Contributor Author

Hi @mihaic do you have any recommendations on how to dislodge these errors?

Thanks!

@mihaic
Copy link
Member

mihaic commented Jul 24, 2023

Hello, @CameronTEllis! @davidt0x has been working on this as part of the testing overhaul in PR #511. See in particular the following commit:
e6fceaf

Would that work? @davidt0x and I are trying to simplify PR #511 and merge it ASAP.

@mihaic mihaic linked an issue Jul 24, 2023 that may be closed by this pull request
Statsmodel reference to import AMRA module is outdated in fmrisim #520
Closed
@CameronTEllis
Copy link
Contributor Author

Hi @mihaic, aha I had no idea @davidt0x was working on this. Yes, that solution does work, it produces equivalent results. So from my read, someone just needs to review and merge #511, correct?

@mihaic
Copy link
Member

mihaic commented Jul 25, 2023

PR #511 still needs some work to make tests pass. @davidt0x is on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statsmodel reference to import AMRA module is outdated in fmrisim
2 participants
@CameronTEllis @mihaic