New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fcma #97

Merged
merged 63 commits into from Sep 22, 2016

Conversation

Projects
None yet
3 participants
@yidawang
Contributor

yidawang commented Aug 28, 2016

  1. add in correlation based voxel selection of FCMA, being able to reproduce the results original FCMA toolbox gets.
  2. provide an example of using correlation based voxel selection of FCMA.
  3. modify setup.py to enable CMake compiling.
Show outdated Hide outdated brainiak/fcma/fcma.py
Show outdated Hide outdated brainiak/fcma/fcma.py
@TuKo

This comment has been minimized.

Show comment
Hide comment
@TuKo

TuKo Aug 29, 2016

Contributor

@yidawang: Did you find any performance difference with the njobs in sklearn?

Contributor

TuKo commented Aug 29, 2016

@yidawang: Did you find any performance difference with the njobs in sklearn?

@yidawang

This comment has been minimized.

Show comment
Hide comment
@yidawang

yidawang Aug 29, 2016

Contributor

@TuKo Not much difference. What is worse, n_jobs=-1 will spawn a bunch of processes which uses up the memory especially when the dataset is large. In any case, we will come up with our own high performance SVM implementation, so I don't worry much about this. Thanks for the suggestion, though.

Contributor

yidawang commented Aug 29, 2016

@TuKo Not much difference. What is worse, n_jobs=-1 will spawn a bunch of processes which uses up the memory especially when the dataset is large. In any case, we will come up with our own high performance SVM implementation, so I don't worry much about this. Thanks for the suggestion, though.

yidawang added some commits Aug 30, 2016

yidawang added some commits Sep 1, 2016

Show outdated Hide outdated setup.py
Show outdated Hide outdated setup.py

yidawang and others added some commits Sep 19, 2016

Compile Cython code during install, not at runtime
Add more string-like methods required by Cython to pybind11 workaround class.

Remove unused `pytest-cython`.

Remove `-fvisibility=hidden` which conflicts with Cython.
Merge pull request #5 from mihaic/fcma-compile-at-install
Compile Cython code during install, not at runtime
Show outdated Hide outdated setup.py
Show outdated Hide outdated tests/fcma/test_voxel_selection.py
Show outdated Hide outdated brainiak/fcma/cython_blas.pyx
Show outdated Hide outdated tests/fcma/test_voxel_selection.py
Show outdated Hide outdated setup.py

yidawang added some commits Sep 21, 2016

Show outdated Hide outdated setup.py
@mihaic

This comment has been minimized.

Show comment
Hide comment
@mihaic

mihaic Sep 22, 2016

Contributor

Jenkins, retest this please.

Contributor

mihaic commented Sep 22, 2016

Jenkins, retest this please.

@mihaic mihaic merged commit e50068d into brainiak:master Sep 22, 2016

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
linux Build finished.
Details
macos Build finished.
Details

@yidawang yidawang deleted the yidawang:fcma branch Sep 22, 2016

danielsuo pushed a commit that referenced this pull request Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment