From e5db7cac1c188329a376398661fd29ac01bd530c Mon Sep 17 00:00:00 2001 From: Brandon Zhang Date: Fri, 14 Oct 2022 15:45:40 +0800 Subject: [PATCH 1/2] Update lowdim_analyzer.py --- brainpy/analysis/lowdim/lowdim_analyzer.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/brainpy/analysis/lowdim/lowdim_analyzer.py b/brainpy/analysis/lowdim/lowdim_analyzer.py index 48c10fb2a..320f0bdee 100644 --- a/brainpy/analysis/lowdim/lowdim_analyzer.py +++ b/brainpy/analysis/lowdim/lowdim_analyzer.py @@ -96,6 +96,9 @@ def __init__( for key in self.target_vars.keys(): if key not in self.model.variables: raise errors.AnalyzerError(f'{key} is not a dynamical variable in {self.model}.') + value = self.target_vars[key] + if value[0] > value[1]: + raise errors.AnalyzerError(f'The range of variable {key} is reversed, which is [{value[0]}, {value[1]}].') # fixed variables # ---------------- @@ -137,6 +140,10 @@ def __init__( for key in target_pars.keys(): if key not in self.model.parameters: raise errors.AnalyzerError(f'"{key}" is not a valid parameter in "{self.model}" model.') + value = self.target_vars[key] + if value[0] > value[1]: + raise errors.AnalyzerError(f'The range of parameter {key} is reversed, which is [{value[0]}, {value[1]}].') + self.target_pars = Collector(target_pars) self.target_par_names = list(self.target_pars.keys()) # list of target_pars From bb3565f21f323c2491a14e7dbb5d79a5c75d1d47 Mon Sep 17 00:00:00 2001 From: Brandon Zhang Date: Sat, 15 Oct 2022 00:06:50 +0800 Subject: [PATCH 2/2] Update lowdim_analyzer.py --- brainpy/analysis/lowdim/lowdim_analyzer.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/brainpy/analysis/lowdim/lowdim_analyzer.py b/brainpy/analysis/lowdim/lowdim_analyzer.py index 320f0bdee..5ec76ca30 100644 --- a/brainpy/analysis/lowdim/lowdim_analyzer.py +++ b/brainpy/analysis/lowdim/lowdim_analyzer.py @@ -98,7 +98,7 @@ def __init__( raise errors.AnalyzerError(f'{key} is not a dynamical variable in {self.model}.') value = self.target_vars[key] if value[0] > value[1]: - raise errors.AnalyzerError(f'The range of variable {key} is reversed, which is [{value[0]}, {value[1]}].') + raise errors.AnalyzerError(f'The range of variable {key} is reversed, which means {value[0]} should be smaller than {value[1]}.') # fixed variables # ---------------- @@ -142,7 +142,7 @@ def __init__( raise errors.AnalyzerError(f'"{key}" is not a valid parameter in "{self.model}" model.') value = self.target_vars[key] if value[0] > value[1]: - raise errors.AnalyzerError(f'The range of parameter {key} is reversed, which is [{value[0]}, {value[1]}].') + raise errors.AnalyzerError(f'The range of parameter {key} is reversed, which means {value[0]} should be smaller than {value[1]}.') self.target_pars = Collector(target_pars) self.target_par_names = list(self.target_pars.keys()) # list of target_pars