Márton Boros brainrape

  • Budapest, Hungary
  • Joined on

Organizations

@wireload @eket
@brainrape
@brainrape
  • @brainrape 132b503
    add xor, isNaN, isFinite to readme
@brainrape
Data.String.Unsafe is very unsafe
@brainrape

Fixed by #27

@brainrape
Char constructor is unsafe
@brainrape

Fixed by #27

@brainrape
@brainrape
@brainrape
@brainrape
  • @brainrape 4687a46
    replace keychain with envoy
@brainrape
@brainrape
brainrape commented on pull request purescript/purescript-tuples#12
@brainrape

indeed, fixed

@brainrape
  • @brainrape 7ba9ec4
    fix zip docs, fix long lines
brainrape commented on pull request purescript/purescript-tuples#12
@brainrape

Instance docs are useful. I would have written one for bindTuple (and the rest) if I knew what the idea was behind it.

brainrape commented on pull request purescript/purescript-tuples#12
@brainrape

The terminology is used throughout the module, and this is where it's introduced.

@brainrape
add some instance docs
1 commit with 56 additions and 4 deletions
brainrape deleted branch update-docs at brainrape/purescript-tuples
@brainrape
@brainrape
brainrape commented on pull request purescript/purescript-strings#27
@brainrape

Good to merge though?

brainrape commented on pull request purescript/purescript-strings#27
@brainrape

We should also think about the interaction with Exceptions, ie catchException will probably catch exceptions inside pure it calls.

brainrape commented on pull request purescript/purescript-strings#27
@brainrape

Array.Unsafe use unsafeIndex, an incomplete pattern match, and Data.Maybe.Unsafe.fromJust

brainrape commented on pull request purescript/purescript-strings#27
@brainrape

I sort of see how unpredictable failure can be a good deterrent from using unsafe functions though.

brainrape commented on pull request purescript/purescript-strings#27
@brainrape

eg Prelude.unsafeIndex just returns undefined doc: Note: this function can cause unpredictable failure at runtime if the index is out-of-bounds. I…

brainrape commented on pull request purescript/purescript-strings#27
@brainrape

Exactly, I was going to suggest that but first I went looking for such occurences. Throwing new Error will show a backtrace, and including the fun…

@brainrape

+1 for including the fixity declaration in the doc

@brainrape