Add a RefundWithRequest method to TransactionGateway #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
approved these changes
Nov 20, 2018
transaction.go
Outdated
| type TransactionRefundRequest struct { | ||
| XMLName string `xml:"transaction"` | ||
| Amount *Decimal `xml:"amount"` | ||
| OrderId string `xml:"order-id,omitempty"` |
There was a problem hiding this comment.
Can we have this parameter OrderID? There's a mix of casings in this package but trying to make new ones consistent with Go standards.
transaction_gateway.go
Outdated
| @@ -140,6 +140,22 @@ func (g *TransactionGateway) Refund(ctx context.Context, id string, amount ...*D | |||
| return nil, &invalidResponseError{resp} | |||
| } | |||
|
|
|||
| // RefundWithRequest is similar to Refund, but allows more parameters such as | |||
| // OrderId to be included as part of the refund request. | |||
The current Refund method cannot take additional parameters like OrderID. This new method allows those parameters to be passed as part of a request structure.
aaronlehmann
force-pushed
the
refund-with-request
branch
from
da1533c
to
d50fc6c
Compare
|
Thanks. I've amended the commit to change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Refundmethod cannot take additional parameters likeOrderId. This new method allows those parameters to be passed as part ofa request structure.
Fixes #276