-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using dropin leaves iframe in body behind #43
Comments
@satazor the iframe that contains the modal does not get destroyed since the "inline" iframe may still have to invoke it at another point in the lifecycle. In the future we are looking to add better lifecycle management including |
The inline iframe gets removed when the modal is closed since it is a descendant of the modal element. So I think it will never get called nor reused since another call to .setup will create another iframe in the body. As an intermediate solution until those methods are available, is it acceptable to remove the outer iframe manually? |
@satazor I am a bit confused. The inline frame and the modal iframe are separate DOM nodes in the document. The inline is not part of the modal frame. The inline frame is the what contains these two views (depending on your state): So we never remove it since you either use it to enter a card or change your selected payment method. Could you shed some more light on your situation? When are you seeing the inline get removed? |
Sorry, forget everything that I've said before. I will try to explain in a more clearer way. The web app we are using In that modal, the product is presented to the user as well as a "proceed to buy" button which instantiates the Hope this is clearer now. If needed I can send you some screenshots to your email. Thank you. |
👍 |
@satazor as you may have seen in issue #29, we recently introduced an update to By calling Let us know if you run into any further issues. |
Hi,
I'm using the dropin widget in a modal dialog. The issue is that if the modal is closed, an "iframe" is left behind in the document.body. I searched for a
destroy
ordispose
method in the component but couldn't find none. At the moment I'm removing the iframe manually, but it doesn't feel right.Am I missing something? Thanks in advance.
The text was updated successfully, but these errors were encountered: