Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Won't build in Xcode 10.2 iOS 12.2 #453

Closed
holgersindbaek opened this issue Apr 8, 2019 · 6 comments

Comments

@holgersindbaek
Copy link

commented Apr 8, 2019

I've downloaded the braintree_ios repo and I'm trying to build the demo with the iOS deployment target set to 12.2, but it's giving me build errors:

Screenshot 2019-04-08 at 12 43 32

I did this because I'm trying to use braintree_ios as a pod in my app, but I can't get it to work on iOS 12.2.

Does anyone else have an issue with using the Braintree iOS pod in iOS 12.2? Will the Braintree iOS library be updated to work with iOS 12.2?

@holgersindbaek holgersindbaek changed the title Won't build in Xcode 10 iOS 12.2 Won't build in Xcode 10.2 iOS 12.2 Apr 8, 2019

@scannillo

This comment has been minimized.

Copy link
Contributor

commented Apr 8, 2019

I just did a fresh pull of the braintree_ios repo, followed by a pod install, and have the demo app running fine on an iPhone Xr simulator running iOS 12.2.

Is your clone of the repo up to date, as well as the other pods it depends on?

@holgersindbaek

This comment has been minimized.

Copy link
Author

commented Apr 8, 2019

If you set the deployment target to 12.2, then it won't build and you'll get the errors seen in the image.

@holgersindbaek

This comment has been minimized.

Copy link
Author

commented Apr 8, 2019

From what I can see, all apps have to be build with iOS 12.0+ deployment target start April 1 this month (https://www.macrumors.com/2018/09/12/apple-ios-12-sdk-required-march-2019/). Am I misunderstanding something?

@janvennemann

This comment has been minimized.

Copy link

commented Apr 12, 2019

I suspect this is due to this line which treats all warnings as errors:

s.compiler_flags = "-Wall -Werror -Wextra"

@holgersindbaek

This comment has been minimized.

Copy link
Author

commented Apr 12, 2019

@janvennemann You're right. I'm using a local version now where I've commented that line out and it seems to work. Thanks!

@wndxlori

This comment has been minimized.

Copy link

commented Apr 15, 2019

No sure closing this is the right thing to do. Either the code needs to be updated, or the podspec needs to be relaxed, or people will keep running into this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.