Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrapping of texts in SummaryView #107

Merged

Conversation

nirinchev
Copy link
Contributor

This should fix #101.

Please note that, since I'm not an Obj C developer, I haven't written any tests to validate correct behaviour. If anyone is more comfortable with the testing frameworks braintree uses, feel free to pick it up and add tests.

Here are two screenshots demonstrating the issue before and after the fix:
Before fix
alt text
After fix
alt text

@mickeyreiss
Copy link
Contributor

Hi @nirinchev! This looks great. Thanks for the code :octocat:

mickeyreiss added a commit that referenced this pull request Mar 16, 2015
@mickeyreiss mickeyreiss merged commit 56b4bb2 into braintree:master Mar 16, 2015
@nirinchev nirinchev deleted the nirinchev/SummaryViewWrapping branch April 6, 2015 21:36
mickeyreiss pushed a commit to mickeyreiss/braintree_ios that referenced this pull request May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Word wrapping for summaryTitle and summaryDescription
2 participants