From f343f0931c2cf87249521c5efcd5f52f8b9b0ebc Mon Sep 17 00:00:00 2001 From: Jeff McCollum Date: Mon, 23 Mar 2026 11:09:20 -0500 Subject: [PATCH] add aws checksum for gcp --- braintrust/templates/api-configmap.yaml | 2 ++ braintrust/tests/api-configmap_test.yaml | 26 ++++++++++++++++++++++++ 2 files changed, 28 insertions(+) diff --git a/braintrust/templates/api-configmap.yaml b/braintrust/templates/api-configmap.yaml index f6414a8..2fe26c5 100644 --- a/braintrust/templates/api-configmap.yaml +++ b/braintrust/templates/api-configmap.yaml @@ -35,6 +35,8 @@ data: ENABLE_GCS_AUTH: "true" {{- else }} AWS_ENDPOINT_URL: "https://storage.googleapis.com" + AWS_REQUEST_CHECKSUM_CALCULATION: "WHEN_REQUIRED" + AWS_RESPONSE_CHECKSUM_VALIDATION: "WHEN_REQUIRED" {{- end }} {{- end }} diff --git a/braintrust/tests/api-configmap_test.yaml b/braintrust/tests/api-configmap_test.yaml index e546c32..d7fc25d 100644 --- a/braintrust/tests/api-configmap_test.yaml +++ b/braintrust/tests/api-configmap_test.yaml @@ -114,6 +114,32 @@ tests: - equal: path: data.AWS_ENDPOINT_URL value: "https://storage.googleapis.com" + - equal: + path: data.AWS_REQUEST_CHECKSUM_CALCULATION + value: "WHEN_REQUIRED" + - equal: + path: data.AWS_RESPONSE_CHECKSUM_VALIDATION + value: "WHEN_REQUIRED" + + - it: should not set checksum vars when enableGcsAuth is true + values: + - __fixtures__/base-values.yaml + - __fixtures__/google-values.yaml + set: + api.enableGcsAuth: true + api.serviceAccount.googleServiceAccount: "test@project.iam.gserviceaccount.com" + release: + namespace: "braintrust" + asserts: + - equal: + path: data.ENABLE_GCS_AUTH + value: "true" + - isNull: + path: data.AWS_ENDPOINT_URL + - isNull: + path: data.AWS_REQUEST_CHECKSUM_CALCULATION + - isNull: + path: data.AWS_RESPONSE_CHECKSUM_VALIDATION - it: should configure brainstore URLs correctly values: