Style Changes #55

Merged
merged 36 commits into from Oct 13, 2015

Conversation

2 participants
@MinchinWeb
Contributor

MinchinWeb commented Oct 9, 2015

This is all the style changes split out of PR #52.

There should be no substantial code changes, just style fixes.

Issues addressed:

  • PEP8 (E125, E127, E128, E201, E202, E203, E221, E225, E231, W291, W293, E301, E302, E303, W391, E501 (selected lines only), E502, E703, and E711)
  • Travis-CI
    • add Python 3.5
    • add Python 3.2, PyPy, and PyPy3 as an 'acceptable failure', allowing interested parties to see how close topydo is to running on those platforms
  • tests
    • rename numbered tests so they sort in order
    • make all of the test file self-runnable
    • rename test files so they start with 'test'. This allows unittest's default auto-discovery to work
  • documentation
    • update the copyright year in the version statement
    • update the copyright year in the header of the code files
    • spellcheck
  • imports
    • sort imports
    • remove unused imports

MinchinWeb added some commits Sep 25, 2015

Rename test files to start with "test"
This allows the default discover on unittest to work
Fix PEP8 E125
continuation line with same indent as next logical line
Fix PEP8 E127
continuation line over-indented for visual indent
Fix PEP8 E128
continuation line under-indented for visual indent
Fix PEP8 E201
whitespace after '('
Fix PEP8 E202
whitespace before ')'
Fix PEP8 E203
whitespace before ':'
Fix PEP8 E221
multiple spaces before operator
Fix PEP8 E225
missing whitespace around operator
Fix PEP8 E231
missing whitespace after ':'
missing whitespace after ','
Fix PEP8 E261
at least two spaces before inline comment
Fix PEP8 W291
trailing whitespace
Fix PEP8 W293
blank line contains whitespace
Fix PEP8 E301
expected 1 blank line, found 0
Fix PEP8 E302
expected 2 blank lines, found 1 (above module level defined classes and
functions)
Fix PEP8 E303
too many blank lines
Fix PEP8 W391
blank line at end of file
Fix PEP8 E501 (selected)
line too long (> 79 characters)
Fix PEP8 E502
the backslash is redundant between brackets
Fix PEP8 E703
statement ends with a semicolon
Fix PEP8 E711
comparison to None should be 'if cond is None:' or 'if cond is not None:'
Sort imports
Sorted using `isort`. Sorted alphabetically, with sections for standard
library, third-party, and then internal imports.
Travis-CI: add Python 3.2, PyPy, and PyPY3 as acceptable failures
Allows monitoring to see how close we are to supporting these on these
platforms.
@bram85

This comment has been minimized.

Show comment
Hide comment
@bram85

bram85 Oct 9, 2015

Owner

Thanks for your patch. Had a quick look at it, seems to look good overall. I'll be out of town for a couple of days, will review it more thoroughly somewhere next week.

Owner

bram85 commented Oct 9, 2015

Thanks for your patch. Had a quick look at it, seems to look good overall. I'll be out of town for a couple of days, will review it more thoroughly somewhere next week.

MinchinWeb added some commits Oct 9, 2015

Fix PEP257 D204
1 blank line required after class docstring
Fix PEP257 D202 (selected)
No blank lines allowed after function docstring
Fix PEP257 D400 (selected)
First line should end with a period
@MinchinWeb

This comment has been minimized.

Show comment
Hide comment
@MinchinWeb

MinchinWeb Oct 9, 2015

Contributor

Sounds great 👍

Contributor

MinchinWeb commented Oct 9, 2015

Sounds great 👍

self.assertEqual(self.errors, "")
- def test_add_dep4(self):
+ def test_add_de04(self):

This comment has been minimized.

@bram85

bram85 Oct 13, 2015

Owner

That's a typo here.

@bram85

bram85 Oct 13, 2015

Owner

That's a typo here.

@bram85

This comment has been minimized.

Show comment
Hide comment
@bram85

bram85 Oct 13, 2015

Owner

Looks great, will merge it despite the minor typo. Thanks a lot for your effort to fix those style issues.

Owner

bram85 commented Oct 13, 2015

Looks great, will merge it despite the minor typo. Thanks a lot for your effort to fix those style issues.

bram85 added a commit that referenced this pull request Oct 13, 2015

@bram85 bram85 merged commit 95861af into bram85:master Oct 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015

Rename tests for undo command
Adhere to standards introduced with #55

mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015

Rename tests for undo command
Adhere to standards introduced with #55

mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015

Rename tests for undo command
Adhere to standards introduced with #55

@MinchinWeb MinchinWeb deleted the MinchinWeb:style branch Oct 14, 2015

MinchinWeb added a commit to MinchinWeb/topydo that referenced this pull request Oct 14, 2015

Update to new style
See pull request #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment