Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Changes #55

Merged
merged 36 commits into from Oct 13, 2015
Merged

Style Changes #55

merged 36 commits into from Oct 13, 2015

Conversation

@MinchinWeb
Copy link
Contributor

MinchinWeb commented Oct 9, 2015

This is all the style changes split out of PR #52.

There should be no substantial code changes, just style fixes.

Issues addressed:

  • PEP8 (E125, E127, E128, E201, E202, E203, E221, E225, E231, W291, W293, E301, E302, E303, W391, E501 (selected lines only), E502, E703, and E711)
  • Travis-CI
    • add Python 3.5
    • add Python 3.2, PyPy, and PyPy3 as an 'acceptable failure', allowing interested parties to see how close topydo is to running on those platforms
  • tests
    • rename numbered tests so they sort in order
    • make all of the test file self-runnable
    • rename test files so they start with 'test'. This allows unittest's default auto-discovery to work
  • documentation
    • update the copyright year in the version statement
    • update the copyright year in the header of the code files
    • spellcheck
  • imports
    • sort imports
    • remove unused imports
MinchinWeb added 30 commits Sep 25, 2015
This allows the default discover on unittest to work
continuation line with same indent as next logical line
continuation line over-indented for visual indent
continuation line under-indented for visual indent
whitespace after '('
whitespace before ')'
whitespace before ':'
multiple spaces before operator
missing whitespace around operator
missing whitespace after ':'
missing whitespace after ','
at least two spaces before inline comment
trailing whitespace
blank line contains whitespace
expected 1 blank line, found 0
expected 2 blank lines, found 1 (above module level defined classes and
functions)
too many blank lines
blank line at end of file
line too long (> 79 characters)
the backslash is redundant between brackets
statement ends with a semicolon
comparison to None should be 'if cond is None:' or 'if cond is not None:'
Sorted using `isort`. Sorted alphabetically, with sections for standard
library, third-party, and then internal imports.
MinchinWeb added 3 commits Oct 9, 2015
Allows monitoring to see how close we are to supporting these on these
platforms.
@bram85
Copy link
Owner

bram85 commented Oct 9, 2015

Thanks for your patch. Had a quick look at it, seems to look good overall. I'll be out of town for a couple of days, will review it more thoroughly somewhere next week.

MinchinWeb added 3 commits Oct 9, 2015
1 blank line required after class docstring
No blank lines allowed after function docstring
First line should end with a period
@MinchinWeb
Copy link
Contributor Author

MinchinWeb commented Oct 9, 2015

Sounds great 👍

self.assertEqual(self.errors, "")

def test_add_dep4(self):
def test_add_de04(self):

This comment has been minimized.

Copy link
@bram85

bram85 Oct 13, 2015

Owner

That's a typo here.

@bram85
Copy link
Owner

bram85 commented Oct 13, 2015

Looks great, will merge it despite the minor typo. Thanks a lot for your effort to fix those style issues.

bram85 added a commit that referenced this pull request Oct 13, 2015
Style Changes
@bram85 bram85 merged commit 95861af into bram85:master Oct 13, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015
Adhere to standards introduced with bram85#55
mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015
Adhere to standards introduced with bram85#55
mruwek added a commit to mruwek/topydo that referenced this pull request Oct 13, 2015
Adhere to standards introduced with bram85#55
@MinchinWeb MinchinWeb deleted the MinchinWeb:style branch Oct 14, 2015
MinchinWeb added a commit to MinchinWeb/topydo that referenced this pull request Oct 14, 2015
See pull request bram85#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.