Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Refactored global flags into a new method.
  • Loading branch information
bramp committed May 13, 2017
1 parent 3429e61 commit 6e23780
Showing 1 changed file with 29 additions and 25 deletions.
Expand Up @@ -563,31 +563,7 @@ protected List<String> build(FFmpegBuilder parent, int pass) {

ImmutableList.Builder<String> args = new ImmutableList.Builder<>();

if (strict != FFmpegBuilder.Strict.NORMAL) {
args.add("-strict", strict.toString());
}

if (!Strings.isNullOrEmpty(format)) {
args.add("-f", format);
}

if (!Strings.isNullOrEmpty(preset)) {
args.add("-preset", preset);
}

if (!Strings.isNullOrEmpty(presetFilename)) {
args.add("-fpre", presetFilename);
}

if (startOffset != null) {
args.add("-ss", toTimecode(startOffset, TimeUnit.MILLISECONDS));
}

if (duration != null) {
args.add("-t", toTimecode(duration, TimeUnit.MILLISECONDS));
}

args.addAll(meta_tags);
addGlobalFlags(parent, args);

if (video_enabled) {
addVideoFlags(parent, args);
Expand Down Expand Up @@ -629,6 +605,34 @@ protected List<String> build(FFmpegBuilder parent, int pass) {
return args.build();
}

protected void addGlobalFlags(FFmpegBuilder parent, ImmutableList.Builder<String> args) {
if (strict != FFmpegBuilder.Strict.NORMAL) {
args.add("-strict", strict.toString());
}

if (!Strings.isNullOrEmpty(format)) {
args.add("-f", format);
}

if (!Strings.isNullOrEmpty(preset)) {
args.add("-preset", preset);
}

if (!Strings.isNullOrEmpty(presetFilename)) {
args.add("-fpre", presetFilename);
}

if (startOffset != null) {
args.add("-ss", toTimecode(startOffset, TimeUnit.MILLISECONDS));
}

if (duration != null) {
args.add("-t", toTimecode(duration, TimeUnit.MILLISECONDS));
}

args.addAll(meta_tags);
}

protected void addAudioFlags(ImmutableList.Builder<String> args) {
if (!Strings.isNullOrEmpty(audio_codec)) {
args.add("-acodec", audio_codec);
Expand Down

0 comments on commit 6e23780

Please sign in to comment.