Skip to content

build system #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 4 tasks
brandly opened this issue Sep 24, 2020 · 1 comment
Open
1 of 4 tasks

build system #101

brandly opened this issue Sep 24, 2020 · 1 comment

Comments

@brandly
Copy link
Owner

brandly commented Sep 24, 2020

i wrote out a comment on the current setup, so here are some notes on how things should work in the future.

currently the dev environment is pretty nice on macos and maybe windows, but the build script only runs on macos, as far as i know. i'm not sure where linux is at in all this.

interrelated goals:

  • good dev env across platforms
  • easy builds across platforms. distributing for another platform should just be a matter of spinning up a github workflow on that platform and running the build.
  • i think we should transition to styled-components (BEM usage #42) because the dev process is unmatched. i tried starting this transition, but the current system didn't seem to allow for it. the app would start and elements would have classes on them generated by styled-components, but the classes had no definitions with seemingly no <style> anywhere in the DOM. it appears to have nice theming support for dark mode, and i think it'd make font changes easy (select font in settings #83)
  • typescript? the code currently has flow types, which was a better type system when the decision was made, but typescript has matured a lot and the community has grown massive. it would make it easier for more people to contribute.

i wasn't aware of electron-builder, but it seems to handle more than electron-packager. i need to read into this more, but here's a popular app that uses it and distributes apps for all platforms.

@brandly
Copy link
Owner Author

brandly commented Sep 11, 2021

this project appears to have a good electron-builder and electron-updater setup: https://github.com/jely2002/youtube-dl-gui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant