Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ID handling in toString #6

Merged
merged 4 commits into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@brandly
Copy link
Owner

commented Apr 5, 2019

fixes #3, fixes #5

@erkal did most of the work in this comment 馃檹

to reiterate, an ID in DOT can be

Any string of alphabetic ([a-zA-Z\200-\377]) characters, underscores ('_') or digits ([0-9]), not beginning with a digit;

as well as

any double-quoted string ("...") possibly containing escaped quotes (")

we were doing a poor job detecting when the double-quotes were needed, but now, i think our showId definition closely mirrors the language spec.


@erkal could you look this over? i'm still not sure if we're handling the \200-\377 correctly. sometimes, i go to graphviz to see what parses and what fails. if i take characters like Char.fromCode 378 and put them in an ID without any quotes, it still parses just fine!

there may still be shortcomings in this package in terms of parsing those characters, but i guess it won't cause any problems if we wrap an ID in quotes when it doesn't need them.

let me know what you think of everything.

@erkal

This comment has been minimized.

Copy link

commented Apr 5, 2019

馃帀
It all looks fine to me!
Now, I have to work :)

@brandly brandly merged commit 63be639 into master Apr 5, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@brandly brandly deleted the hex-color branch Apr 5, 2019

@brandly

This comment has been minimized.

Copy link
Owner Author

commented Apr 6, 2019

published in v1.1.1 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.